Daniel Kinzler [Mon, 5 Mar 2012 11:53:21 +0000 (11:53 +0000)]
integration with Title and Revision (work in progress)
Daniel Kinzler [Wed, 1 Feb 2012 22:07:47 +0000 (22:07 +0000)]
first brain dump for ContentHandler interface
Aaron Schulz [Tue, 31 Jan 2012 22:03:36 +0000 (22:03 +0000)]
Added PurgeDeletedFiles script to purge recently deleted files. To be used before initial Swift thumbnail deploy.
Aaron Schulz [Tue, 31 Jan 2012 21:52:58 +0000 (21:52 +0000)]
Expanded 'shardViaHashLevels' config var in FileBackendStore to be able to recognize FileRepo-style deleted zone hash paths (which are different than for the other zones).
Raimond Spekking [Tue, 31 Jan 2012 20:31:52 +0000 (20:31 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Tue, 31 Jan 2012 15:56:17 +0000 (15:56 +0000)]
Followup r110001
Add BadTitleError to AutoLoader.php
Amir E. Aharoni [Tue, 31 Jan 2012 14:47:12 +0000 (14:47 +0000)]
"isset( $forms[2] )" is not needed - plural is filled in preConvertPlural if dual is not provided.
Amir E. Aharoni [Tue, 31 Jan 2012 14:42:38 +0000 (14:42 +0000)]
Testing the case when dual is not provided.
Amir E. Aharoni [Tue, 31 Jan 2012 13:49:36 +0000 (13:49 +0000)]
Adding tests for plural in Hebrew.
Alexandre Emsenhuber [Tue, 31 Jan 2012 10:26:22 +0000 (10:26 +0000)]
Added 'page_id' to the fields returned by Revision::selectPageFields() so that the Title object created in Revision::__construct() already knows its id and it doesn't have to issue another DB query to load it (happens e.g. in api.php?action=parse&oldid=... calls)
Alexandre Emsenhuber [Tue, 31 Jan 2012 10:22:17 +0000 (10:22 +0000)]
Added missing __METHOD__ parameter to DatabaseBase::selectField() calls in ExternalStoreDB
Mark A. Hershberger [Tue, 31 Jan 2012 01:02:01 +0000 (01:02 +0000)]
revert r110340 after talking with krinle
Aaron Schulz [Mon, 30 Jan 2012 23:44:34 +0000 (23:44 +0000)]
(bug 33992) - "Allow anon a formless purge with POST". Changed HTMLForm::tryAuthorizedSubmit() to (a) require post for forms that are supposed to be posted and (b) bypass the token check for anons as it doesn't really do much except be slightly annoying. The tokens are just User::EDIT_TOKEN_SUFFIX in that case.
Mark A. Hershberger [Mon, 30 Jan 2012 23:07:08 +0000 (23:07 +0000)]
Fixes bug 34036 - [regression] mw.loader.load doesn't works as importScriptURI for some kinds of URLs
Patch from Helder.wiki
Alexandre Emsenhuber [Mon, 30 Jan 2012 21:09:48 +0000 (21:09 +0000)]
Use local context to get messages instead of relying on global variables
Alexandre Emsenhuber [Mon, 30 Jan 2012 20:23:01 +0000 (20:23 +0000)]
Use Language::userTimeAndDate() instead of Language::timeanddate() to display timestamp with user preferences
Krinkle [Mon, 30 Jan 2012 19:45:38 +0000 (19:45 +0000)]
[Xml::encodeJsVar] Use FormatJson::encode / native json_encode instead
* Follows-up r110320
* XmlTest.php passes
Krinkle [Mon, 30 Jan 2012 19:40:20 +0000 (19:40 +0000)]
[Xml::encodeJsVar] Change to match FormatJson::encode output
- Pure whitespace change
- In preparation to deprecate it in favor of FormatJson / json_encode
Krinkle [Mon, 30 Jan 2012 19:34:43 +0000 (19:34 +0000)]
[jquery.qunit.completenessTest.js] typo
Krinkle [Mon, 30 Jan 2012 18:35:38 +0000 (18:35 +0000)]
[shared.css] Fix preferences CSS bug
* Apply r109054 fix from branches/RL2 to trunk
-- width: 0; doesn't work and still leaves the column open to free interpretation by the browsers. causing inconsistent widths for the "no label" columns when there are multiple of those tables on one page.
* Also dropping unneeded "!important".
Antoine Musso [Mon, 30 Jan 2012 17:36:43 +0000 (17:36 +0000)]
rv r87948 "fix backtrace on SQL error"
Looks unneeded nowaday. Backtrace is correctly appended to HTML output
or CLI output when $wgShowDBErrorBacktrace is true.
Not sure what it was supposed to fix.
Antoine Musso [Mon, 30 Jan 2012 16:33:36 +0000 (16:33 +0000)]
align $wgActions array values
ping r109195
Antoine Musso [Mon, 30 Jan 2012 15:54:46 +0000 (15:54 +0000)]
make sure we test normalization against normalized title
This patch fix ApiQueryTest::testTitlesGetNormalized() when $wgMetaNamespace
would contains space / underscore.
Example:
-8<-------------8<------------8<------------------8<----------8<------
1) ApiQueryTest::testTitlesGetNormalized
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
'from' => 'Project:articleA'
- 'to' => 'My_Project:ArticleA'
+ 'to' => 'My Project:ArticleA'
)
-8<-------------8<------------8<------------------8<----------8<------
This patch use Title class logic to forge a normalized title instead of
manually creating it by appending two strings.
Final fix to bug 33663 (comment 21):
https://bugzilla.wikimedia.org/show_bug.cgi?id=33663#c21
Siebrand Mazeland [Mon, 30 Jan 2012 13:54:43 +0000 (13:54 +0000)]
Revert r110285, r110286. No new features in core during slush.
Consider recommit after 1.19 is branched, and please add hooks.txt documentation, too.
Santhosh Thottingal [Mon, 30 Jan 2012 13:51:04 +0000 (13:51 +0000)]
Followup r110279. $count % 100 in 1..19 is few form.
In r110279, it was 2..19.
Jeroen De Dauw [Mon, 30 Jan 2012 12:54:17 +0000 (12:54 +0000)]
follow up to r110285, fixed accidental newline
Jeroen De Dauw [Mon, 30 Jan 2012 12:52:31 +0000 (12:52 +0000)]
add hook that allows changing the check to see if a page exists or not
Jeroen De Dauw [Mon, 30 Jan 2012 12:24:24 +0000 (12:24 +0000)]
fix xss
Santhosh Thottingal [Mon, 30 Jan 2012 11:40:28 +0000 (11:40 +0000)]
phpunit testcases for lv, mg,and ml languages to test Plural
Santhosh Thottingal [Mon, 30 Jan 2012 11:34:36 +0000 (11:34 +0000)]
For Moldavian $count % 100 < 20 is not 'few' form, but $count % 100 in 1..19 is few form.
This was causing 200 considered as 'few' form, while it should be 'other' form as per
http://unicode.org/repos/cldr-tmp/trunk/diff/supplemental/language_plural_rules.html#mo
Add phpunit test cases for LanguageMo plural rules
Antoine Musso [Mon, 30 Jan 2012 11:33:16 +0000 (11:33 +0000)]
comment mAction / whitespaces
ping r110245
Antoine Musso [Mon, 30 Jan 2012 11:08:45 +0000 (11:08 +0000)]
drop default parameters from r110252
Html::nmaespaceSelector() generate a select using 'namespace' value
for both 'id' and 'name'. Hence passing:
array( 'name' => 'namespace', 'id' => 'namespace' )
is not needed.
Antoine Musso [Mon, 30 Jan 2012 11:02:56 +0000 (11:02 +0000)]
comment / style for Html::namespaceSelector()
Xml.php:
* align array values. Easier to the eyes.
Html.php:
* Various comments
* Switched the way the HTML is forged
Ping r109990
Antoine Musso [Mon, 30 Jan 2012 10:39:51 +0000 (10:39 +0000)]
test Html::namespaceSelector() id & name attributes generation
Method was introduced by r109990.
Sam Reed [Mon, 30 Jan 2012 10:15:20 +0000 (10:15 +0000)]
Bug 34032 - API help header not aligned
$ocd++;
Antoine Musso [Mon, 30 Jan 2012 08:10:19 +0000 (08:10 +0000)]
@since for r105919 (hasVariant / getConverter)
Aaron Schulz [Mon, 30 Jan 2012 08:00:19 +0000 (08:00 +0000)]
* r108353: Made FileBackendMultiWrite consistency checks configurable.
* Removed redundant code from r110259 and added a comment to isValidContainerName().
Aaron Schulz [Sun, 29 Jan 2012 22:22:28 +0000 (22:22 +0000)]
Renamed FileBackend to FileBackendStore and ugly FileBackendBase to FileBackend. Callers doing things like FileBackend::extensionFromPath() are now more proper.
Alexandre Emsenhuber [Sun, 29 Jan 2012 22:02:27 +0000 (22:02 +0000)]
Code cleanup:
* Group global declarations at the top
* Move wfGetDB() near where it's used
* Only do some stuff when really necessary
Aaron Schulz [Sun, 29 Jan 2012 21:28:31 +0000 (21:28 +0000)]
In FileBackendBase/FileBackend:
* Moved some public static functions from FileBackend to FileBackendBase as the later defines the public API.
* Made splitStoragePath() return null if the backend or container name is empty.
* Made normalizeContainerPath() kill leading directory separators.
* Added more unit tests and made some documentation tweaks.
In FSFileBackend:
* Added resolveContainerName() to disallow '.' a container name, since this would cause a traversal.
Alexandre Emsenhuber [Sun, 29 Jan 2012 20:35:32 +0000 (20:35 +0000)]
Use the WikiPage object object instead of Title to get the page id and latest revision
Raimond Spekking [Sun, 29 Jan 2012 19:41:17 +0000 (19:41 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Sun, 29 Jan 2012 19:40:11 +0000 (19:40 +0000)]
Add support for loading mediawiki.util from the top by default
* Introduces $wgPreloadJavaScriptMwUtil
* Instead of loading mediawiki.util as base module from the bottom, now loading it from queue position "top" if $wgPreloadJavaScriptMwUtil is true. And if false it'll remain in the bottom in practice as implied by other modules loading it as a dependency (i.e. mediawiki.page.ready depends on it)
* Fixes bug 33746
Aaron Schulz [Sun, 29 Jan 2012 19:23:26 +0000 (19:23 +0000)]
* Split up process cache in FileBackend into separate arrays for expensive and inexpensive entries. Put the local reference FSFile object cache in the former since it takes up disk space on /tmp.
* Removed FileBackendBase::resolveWikiId(); doesn't really work well with FileBackendMultiWrite and the functionality is best handled in resolveContainerName(). Follows-up r108303.
* Gave FileOp::doAttempt() a default implementation (a no-op) to be more libertarian.
* Some documentation tweaks.
Krinkle [Sun, 29 Jan 2012 19:05:25 +0000 (19:05 +0000)]
[specials] Xml::namespaceSelector > Html::namespaceSelector
* Makes front-end more reliable by not relying on Xml::namespaceSelector to use name="namespace" in it's output, which these forms where then requesting hardcoded from WebRequest
* Poke r109990
Alexandre Emsenhuber [Sun, 29 Jan 2012 19:05:04 +0000 (19:05 +0000)]
* (bug 33967) "Previous revision" and "Newer revision" links now display the correct revision
(No RELEASE-NOTES entry since that's a 1.19-only bug)
Jeroen De Dauw [Sun, 29 Jan 2012 15:24:06 +0000 (15:24 +0000)]
fix doc and var names
Jeroen De Dauw [Sun, 29 Jan 2012 15:23:23 +0000 (15:23 +0000)]
allow people to actually specify post targets with a query
Max Semenik [Sun, 29 Jan 2012 12:49:14 +0000 (12:49 +0000)]
Add function present in ordinary converter to FakeConverter
Aaron Schulz [Sun, 29 Jan 2012 11:33:47 +0000 (11:33 +0000)]
Added addMissingMetadata() function to SwiftFileBackend to retroactively add metadata (sha1) on the fly. This can be useful if files were imported from some script that doesn't set the metadata.
Jeroen De Dauw [Sun, 29 Jan 2012 05:37:49 +0000 (05:37 +0000)]
this is no longer a guideline afaik
Aaron Schulz [Sat, 28 Jan 2012 20:54:19 +0000 (20:54 +0000)]
In LockServerDaemon:
* r109802: fixed references to bogus vars that are now in LockHolder.
* Tweaked doCommand() so that if a client re-connects, it's removed from the deadSessions member.
* Made all socket operations non-blocking. Uses new SocketArray helper class.
* Bumped default 'maxLocks' parameter to 10000.
Raimond Spekking [Sat, 28 Jan 2012 20:37:44 +0000 (20:37 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Sat, 28 Jan 2012 17:05:20 +0000 (17:05 +0000)]
Fix unused variables
Fix trailing whitespace
Add/Improve documentation
Explicit member variable declaration
Krinkle [Sat, 28 Jan 2012 16:56:10 +0000 (16:56 +0000)]
Fix jquery.client.test breakage
* Remove both classes before adding one. Previously test ran normally on an "ltr" page because the loop starts with "ltr" and they matches naturally. It broke on pages that started out with "rtl". Fixed now
* Restored body classes after the test, otherwise both "rtl" and "ltr" would be gone, could influence other tests and layout stuff on the page.
* Follows-up r101845
Krinkle [Sat, 28 Jan 2012 16:26:12 +0000 (16:26 +0000)]
[Special:MovePage] Split new title input, fix bug 29454 (byteLimit), namespaceSelector
* Two reasons:
-- Limit bug: Limit can't be enforced if the two are together
because only page_title is limited, the namespace prefix
is not part of the title. Plus even then, there is still
ambiguity with the various ways to denote namespaces (aliases)
and whitespace freedom between namespace, colon and title.
-- Extra feature: Now that the two are separate it' s easier
for users to move across namespaces as one doesn't have to type,
can't make spelling mistakes. Also, in the future we could exclude
certain target namespaces that are not possible or not allowed (now one can
perfectly submit a request to move from NS_CATEGORY or NS_FILE, only to
get a warning on submission). By showing them disabled in the drop down
this becomes clearer).
* Keeps backwards compatibility for gadgets and permalinks generated
by templates on wikis so that they can still pre-set the "new title"
from a url the old way. The new way can also be pre-set from the url,
and allows them to be set separately (wpNewTitleNs=10&wpNewTitleMain=Infobox)
* Gadgets and templates linking to Special:MovePage with a preset target
-- Old way (still works): wpNewTitle=Template:Infobox
-- New way: wpNewTitleNs=10 (and/or) wpNewTitleMain=Infobox
* Fixes bug 29454; Depends on r109990;
-- (bug 29454) Enforce byteLimit for page title input on Special:MovePage
Aaron Schulz [Sat, 28 Jan 2012 01:20:42 +0000 (01:20 +0000)]
* In NewParserTest, made it possible to use the --use-filebackend param to run the tests on a given registered backend.
* In FileBackendTest, killed useless recursiveClean() call.
Aaron Schulz [Sat, 28 Jan 2012 00:43:55 +0000 (00:43 +0000)]
r110180: fixed copy-paste cruft for custom backend code. Also made backend names consistent.
Aaron Schulz [Sat, 28 Jan 2012 00:16:20 +0000 (00:16 +0000)]
Reverted r109957 per slush (see CR comments)
Sam Reed [Fri, 27 Jan 2012 23:19:58 +0000 (23:19 +0000)]
Use accessor method, ping r110179
Aaron Schulz [Fri, 27 Jan 2012 22:57:14 +0000 (22:57 +0000)]
Killed the metric arseload of test folders that were being leaked and killing jenkins
Aaron Schulz [Fri, 27 Jan 2012 22:46:55 +0000 (22:46 +0000)]
Fixed a bunch of dir leakage
Bryan Tong Minh [Fri, 27 Jan 2012 22:44:46 +0000 (22:44 +0000)]
Follow-up r83791: do not show size links for wikis which do not use a 404 transform, since this is a rather expensive operation, which can delay loading for several seconds.
Jeroen De Dauw [Fri, 27 Jan 2012 22:11:57 +0000 (22:11 +0000)]
added kml mime type
mrbluesky [Fri, 27 Jan 2012 22:07:09 +0000 (22:07 +0000)]
Comments only
Alexandre Emsenhuber [Fri, 27 Jan 2012 21:21:19 +0000 (21:21 +0000)]
Use WikiPage instead of Article to call doDeleteArticle()
Sam Reed [Fri, 27 Jan 2012 21:16:47 +0000 (21:16 +0000)]
Yay, https
Alexandre Emsenhuber [Fri, 27 Jan 2012 21:13:25 +0000 (21:13 +0000)]
* Group related functions
* Moved isCountable() and redirect-related function a bit downward
Platonides [Fri, 27 Jan 2012 21:06:00 +0000 (21:06 +0000)]
The if should check $commentText, not $f, which is always set in this branch.
Raimond Spekking [Fri, 27 Jan 2012 20:44:55 +0000 (20:44 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Fri, 27 Jan 2012 20:35:42 +0000 (20:35 +0000)]
Follow-up r110159: set the FilesystemIterator flags when that class is available (PHP >= 5.3). Apparently, some versions of PHP 5.3 have different defaults that others for SKIP_DOTS.
Aaron Schulz [Fri, 27 Jan 2012 20:12:50 +0000 (20:12 +0000)]
* Reverted r108194 to support PHP < 5.3. These should already be the default iterator settings.
* Also made the iterator keys (e.g. in foreach) more consistent by being integers as the other backend iterators do.
Aaron Schulz [Fri, 27 Jan 2012 18:23:40 +0000 (18:23 +0000)]
r107980: added missing dir param to FileBackendShardListIterator
Aaron Schulz [Fri, 27 Jan 2012 18:21:58 +0000 (18:21 +0000)]
r107980: added missing dir param to FileBackendShardListIterator
Sam Reed [Fri, 27 Jan 2012 15:03:50 +0000 (15:03 +0000)]
Fix spurious character from r110122
Chad Horohoe [Fri, 27 Jan 2012 14:33:43 +0000 (14:33 +0000)]
Self-revert r110124, needs more than that to support 5.2 since $flags don't exist in 5.2.
Either this needs to be fixed to really support 5.2 or we'll bumping the minimum version to 5.3 this release.
Sam Reed [Fri, 27 Jan 2012 14:30:40 +0000 (14:30 +0000)]
Add documentation
Fix whitespace
Chad Horohoe [Fri, 27 Jan 2012 14:29:29 +0000 (14:29 +0000)]
Copy FilesystemIterator constants so we can still pretend to support 5.2
Sam Reed [Fri, 27 Jan 2012 14:29:29 +0000 (14:29 +0000)]
$this->substPaths takes 2 parameters
protected function substPaths( $paths, FileBackend $backend ) {
Pass $backend from the for loop
Sam Reed [Fri, 27 Jan 2012 14:15:29 +0000 (14:15 +0000)]
Fix undefined $dirRoot
Chad Horohoe [Fri, 27 Jan 2012 13:27:26 +0000 (13:27 +0000)]
Minor tweak to r109161, remove trailing "this"
Chad Horohoe [Fri, 27 Jan 2012 13:00:26 +0000 (13:00 +0000)]
Fixup r109698, add setter for $namespaceNames and use proper accessors in the tests.
Since we're here: nothing uses $namespaceNames, $mNamespaceIds or $namespaceAliases
outside of this class (core or extensions) so lets make it protected.
Santhosh Thottingal [Fri, 27 Jan 2012 11:13:06 +0000 (11:13 +0000)]
Add PHPUnit tests for plural rules. For languages cs, cu, cy, dsb, fr, ga, gd, gv, hr, hsb, hy, ksh, ln
Max Semenik [Fri, 27 Jan 2012 10:00:42 +0000 (10:00 +0000)]
Compressed a few images
Alexandre Emsenhuber [Fri, 27 Jan 2012 07:23:55 +0000 (07:23 +0000)]
Use Language::userTimeAndDate() and related to get the time with user preferences instead of Language::timeanddate() and related
Alexandre Emsenhuber [Fri, 27 Jan 2012 07:15:18 +0000 (07:15 +0000)]
* (bug 33762) QueryPage-based special pages no longer misses *-summary message
Santhosh Thottingal [Fri, 27 Jan 2012 06:01:43 +0000 (06:01 +0000)]
phpunit testcases on the plural rules for am, ar, be, be_tarask, bh, bs and hi languages
Santhosh Thottingal [Fri, 27 Jan 2012 05:58:46 +0000 (05:58 +0000)]
Use dataprovider for testcases.
Chad Horohoe [Thu, 26 Jan 2012 22:08:38 +0000 (22:08 +0000)]
(bug 33911) SiteStats::isSane() should not check admins anymore
Chad Horohoe [Thu, 26 Jan 2012 22:04:55 +0000 (22:04 +0000)]
Remove last two vestiges of ss_admins. It still exists in some schema files, but those are harmless
Aaron Schulz [Thu, 26 Jan 2012 21:05:03 +0000 (21:05 +0000)]
In FileBackendBase/FileBackend:
* Added normalizeStoragePath() function. Use it for normalizing paths in the stat cache. This way, if someone clears a non-normal form of path from the cache, it will actually work as expected.
* Removed 'abstract' flag from FileBackendBase::clearCache().
* Documentation tweaks.
Raimond Spekking [Thu, 26 Jan 2012 20:39:48 +0000 (20:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Aaron Schulz [Thu, 26 Jan 2012 20:17:18 +0000 (20:17 +0000)]
Further reduced RTTs in SwiftFileBackend by making "file already exists" checks use the stat cache, typically already set in FileOp::doPrecheck(). FileBackendBase::doOperationsInternal() already clears the cache after locking (and before FileOp::attemptBatch) for consistency.
Platonides [Thu, 26 Jan 2012 17:16:41 +0000 (17:16 +0000)]
Unused global
Alexandre Emsenhuber [Thu, 26 Jan 2012 16:44:29 +0000 (16:44 +0000)]
* Do the page existence check before calling ignore_user_abort() so that we don't return after having modified that value
* Change the check to use $oldid since we already have the result of getLatest()
Antoine Musso [Thu, 26 Jan 2012 14:55:38 +0000 (14:55 +0000)]
update Message class doc
Ping r110054
Chad Horohoe [Thu, 26 Jan 2012 13:45:50 +0000 (13:45 +0000)]
Fix r110054, \ -> @
Antoine Musso [Thu, 26 Jan 2012 11:34:30 +0000 (11:34 +0000)]
enhance doxygen generation for Message class
Neil Kandalgaonkar [Thu, 26 Jan 2012 02:15:04 +0000 (02:15 +0000)]
sanitize outgoing messages
Aaron Schulz [Wed, 25 Jan 2012 23:11:53 +0000 (23:11 +0000)]
* In NewParserTest, refactored code to use FileBackend (bug 31737). Also made some speed improvements and made regex= not flood the output with 600 items of crap.
* In FileBackendTest, call clean() on the dirs *after* deleting all the files first.
* Speed improvements to MediaWikiTestCase.